Matthias Clasen [Mon, 3 Aug 2020 01:11:30 +0000 (21:11 -0400)]
gtk-demo: Avoid invalid OpenType feature tags
ss00 doesn't exist, and we use xxxx as placeholder
for 'default' choices in alternatives. Add a warning
in case we run across invalid OpenType feature tags
in fonts.
Fixes: #2962
Matthias Clasen [Mon, 3 Aug 2020 00:23:28 +0000 (00:23 +0000)]
Merge branch 'filechooser-completions' into 'master'
filechooser: Prevent over-eager completions
Closes #2995
See merge request GNOME/gtk!2347
Matthias Clasen [Mon, 3 Aug 2020 00:23:13 +0000 (00:23 +0000)]
Merge branch 'wip/chergert/gtk4-textview-fix-selections' into 'master'
textlinedisplaycache: short-circuit y_range invalidation
Closes #2975
See merge request GNOME/gtk!2348
Matthias Clasen [Mon, 3 Aug 2020 00:19:43 +0000 (00:19 +0000)]
Merge branch 'fix-win32-ci' into 'master'
ci: Don't use --werror for the win32 build
See merge request GNOME/gtk!2349
Matthias Clasen [Sun, 2 Aug 2020 23:59:25 +0000 (19:59 -0400)]
ci: Don't use --werror for the win32 build
This leads to warnings from the glib win32 build
failing our ci. Only use werror for gtk itself.
Christian Hergert [Sun, 2 Aug 2020 23:35:50 +0000 (16:35 -0700)]
textlinedisplaycache: short-circuit y_range invalidation
If we have a y==-1 then we are generally invalidating the whole textview.
For this case, we can just discard the entire GtkTextLineDisplay cache.
Fixes #2975
Matthias Clasen [Sun, 2 Aug 2020 23:18:11 +0000 (19:18 -0400)]
filechooser: Prevent over-eager completions
We don't want the completions to pop up after we call
gtk_file_chooser_set_current_name(). This used to be
handled by gtk_entry_set_text() blocking the completion
signal handler. We don't have that anymore, so block
popup completion around the call to gtk_editable_set_text()
instead.
Fixes: #2995
Matthias Clasen [Sun, 2 Aug 2020 23:17:40 +0000 (23:17 +0000)]
Merge branch 'grid-api' into 'master'
grid layout: Rename some properties
Closes #2967
See merge request GNOME/gtk!2345
Matthias Clasen [Sun, 2 Aug 2020 19:10:18 +0000 (15:10 -0400)]
builder-tool: Rewrite top/left-attach
Rewrite the GtkGrid:top/left-attach child properties
to the GtkGridLayoutChild:row/column layout properties.
Update expected test output to match.
Matthias Clasen [Sun, 2 Aug 2020 18:13:14 +0000 (14:13 -0400)]
grid layout: Rename some properties
Rename GtkGridLayoutChild:left-attach/top-attach to
GtkGridLayoutChild:column/row. Update all users.
Fixes: #2967
Matthias Clasen [Sun, 2 Aug 2020 21:55:43 +0000 (21:55 +0000)]
Merge branch 'fix-textiter-tests' into 'master'
textbuffer: Fix a test failure
See merge request GNOME/gtk!2346
Matthias Clasen [Sun, 2 Aug 2020 21:23:26 +0000 (17:23 -0400)]
textbuffer: Fix a test failure
The previous change to gtktextbuffer.c was breaking
the textiter testcase.
Matthias Clasen [Sun, 2 Aug 2020 17:54:06 +0000 (13:54 -0400)]
textbuffer: Be careful with tags when copying
We can only insert tags in the buffer if they come
from the same GtkTextTagTable as the buffer uses.
If that is not the case, paste the text without tags.
Fixes: #2991
Matthias Clasen [Sun, 2 Aug 2020 17:45:30 +0000 (17:45 +0000)]
Merge branch 'text-drag-select' into 'master'
textview: Only claim the event when appropriate
Closes #2999
See merge request GNOME/gtk!2344
Matthias Clasen [Sun, 2 Aug 2020 17:42:22 +0000 (17:42 +0000)]
Merge branch 'fallback-menu-critical' into 'master'
popovermenu: Avoid a critical
Closes #2998
See merge request GNOME/gtk!2343
Matthias Clasen [Sun, 2 Aug 2020 17:31:15 +0000 (13:31 -0400)]
textview: Only claim the event when appropriate
Don't claim the event unconditionally for the click gesture,
since we may want to start a drag selection.
Fixes: #2999
Matthias Clasen [Sun, 2 Aug 2020 17:09:00 +0000 (13:09 -0400)]
popovermenu: Avoid a critical
While we guarantee that the widget that a controller
is attached to stays around while it is handling an event,
the same is not true for the root that the widget belongs
to. In corner cases (such as clicking "Close" in the
fallback window menu), it may already be gone.
Avoid a critical in that case.
Fixes: #2998
Matthias Clasen [Sun, 2 Aug 2020 16:40:12 +0000 (16:40 +0000)]
Merge branch 'selectable-label-draw' into 'master'
label: Redraw when focus changes
See merge request GNOME/gtk!2342
Matthias Clasen [Sun, 2 Aug 2020 16:39:59 +0000 (16:39 +0000)]
Merge branch 'linked-button-fixes' into 'master'
Adwaita: Add linked styling for particular button widgets
Closes #2939 and #1903
See merge request GNOME/gtk!2339
Matthias Clasen [Sun, 2 Aug 2020 16:25:50 +0000 (16:25 +0000)]
Merge branch 'controllers-list' into 'master'
Controllers list
See merge request GNOME/gtk!2341
Matthias Clasen [Sun, 2 Aug 2020 15:24:27 +0000 (11:24 -0400)]
label: Redraw when focus changes
When focus changes in a selectable label, we need to
redraw to make the text caret (dis)appear.
Matthias Clasen [Sun, 2 Aug 2020 16:00:46 +0000 (12:00 -0400)]
Go back to keeping a list of event controllers
This reverts
4b9e5304cc1f675d2. It caused a number of regressions,
such as event controller ordering changes.
Matthias Clasen [Sun, 2 Aug 2020 15:54:29 +0000 (11:54 -0400)]
Revert "Add gtk_widget_prepend_controller"
This reverts commit
692cc42e1023ec439d2fa1a0b9456e8cbfe1cec8.
Matthias Clasen [Sun, 2 Aug 2020 15:54:03 +0000 (11:54 -0400)]
Revert "entry completion: Make keynav work again"
This reverts commit
53a30eaa12e44a2ee5da7c9bc9a23a8bfeb733dc.
Matthias Clasen [Sun, 2 Aug 2020 15:05:17 +0000 (15:05 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
shortcutswindow: Clear search entry on unmap
Closes #2981
See merge request GNOME/gtk!2340
Matthias Clasen [Sun, 2 Aug 2020 13:33:52 +0000 (09:33 -0400)]
shortcutswindow: Clear search entry on unmap
Otherwise, the search term will linger around until
somebody clicks the search button again.
Fixes: #2981
Piotr Drąg [Sun, 2 Aug 2020 12:36:18 +0000 (14:36 +0200)]
Update Polish translation
nana-4 [Sun, 2 Aug 2020 09:48:54 +0000 (18:48 +0900)]
Adwaita: Add linked styling for particular button widgets
Those button widgets need some special linked styling like what
combobox has.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/1903
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2939
nana-4 [Sun, 2 Aug 2020 09:26:40 +0000 (18:26 +0900)]
appchooserbutton: Set a CSS name
Otherwise it has a CSS name "widget".
Matthias Clasen [Sun, 2 Aug 2020 03:47:22 +0000 (03:47 +0000)]
Merge branch 'ci-installed-tests' into 'master'
Run installed tests in ci
Closes #2966
See merge request GNOME/gtk!2335
Matthias Clasen [Sun, 2 Aug 2020 03:25:33 +0000 (03:25 +0000)]
Merge branch 'inspector-device-details' into 'master'
inspector: Introspect enum values
See merge request GNOME/gtk!2338
Matthias Clasen [Sun, 2 Aug 2020 02:42:25 +0000 (22:42 -0400)]
cups: Don't emit a warning if we can't talk to avahi
The g_warning in this case makes the templates test
fail if it can't connect to the system bus (as is the
case for running installed tests in ci).
Matthias Clasen [Sun, 2 Aug 2020 02:30:06 +0000 (22:30 -0400)]
installed-tests: Fix the icontheme test
We forgot to install some of the icons, causing
the test to fail.
Matthias Clasen [Sun, 2 Aug 2020 01:25:29 +0000 (21:25 -0400)]
ci: Add a build that runs installed tests
This will hopefully prevent regressions in
installed-tests.
Matthias Clasen [Sun, 2 Aug 2020 03:05:24 +0000 (23:05 -0400)]
inspector: Introspect enum values
Stop hardcoding arrays with names for enum values.
This has bitten us repeatedly as these enums were
changed around; time to stop doing it.
Matthias Clasen [Sun, 2 Aug 2020 02:45:53 +0000 (02:45 +0000)]
Merge branch 'label-copy-link-fix' into 'master'
Label copy link fix
See merge request GNOME/gtk!2337
Matthias Clasen [Sun, 2 Aug 2020 02:45:30 +0000 (02:45 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
testsuite: Fix installed tests
Closes #2966
See merge request GNOME/gtk!2336
Matthias Clasen [Sun, 2 Aug 2020 01:39:02 +0000 (21:39 -0400)]
ci: Use newer fedora image
v22 adds gnome-desktop-testing-runner and enables sudo.
Matthias Clasen [Sun, 2 Aug 2020 02:11:07 +0000 (22:11 -0400)]
ci: Enable sudo in the image
This is needed so we can install what we built.
Matthias Clasen [Sun, 2 Aug 2020 01:26:35 +0000 (21:26 -0400)]
ci: Add gnome-desktop-testing to images
Matthias Clasen [Sun, 2 Aug 2020 01:23:34 +0000 (21:23 -0400)]
testsuite: Fix installed tests
This broken recently, when we converted the tests
array to a dictionary.
Fixes: #2966
Matthias Clasen [Sun, 2 Aug 2020 01:23:34 +0000 (21:23 -0400)]
testsuite: Fix installed tests
This broken recently, when we converted the tests
array to a dictionary.
Fixes: #2966
Matthias Clasen [Sun, 2 Aug 2020 02:03:06 +0000 (22:03 -0400)]
menusectionbox: Avoid a critical warning
The popover may already be gone when the item
is activated. Don't trigger a critical in that
case.
Related: #2986
Matthias Clasen [Sun, 2 Aug 2020 02:01:52 +0000 (22:01 -0400)]
label: Be more selective when selecting on focus-in
We don't want to select on focus-in when the focus
comes from a child. The case where this does harm
is when you activate copy or paste actions from the
context menu. We close the menu before triggering the
action, and if that causes the text in the label to
be selected, unexpected things happen, since the action
applies to the current selection.
This is the equivalent of
cd9f5733b3e354301f2 for GtkLabel.
Matthias Clasen [Sun, 2 Aug 2020 01:30:31 +0000 (01:30 +0000)]
Merge branch 'glib-build-fix' into 'master'
togglebutton: Don't crash on click
See merge request GNOME/gtk!2334
Matthias Clasen [Sun, 2 Aug 2020 00:09:05 +0000 (20:09 -0400)]
togglebutton: Don't crash on click
The code used to do
if (parent_class->clicked)
parent_class->clicked (...)
That is pointless because the parent_class never changes,
so there' no need for that if and commit
415946eb0f3b76ba25
took it out. Unfortunately, p arent_class->clicked is NULL
though, so the whole call needs to go.
Matthias Clasen [Sat, 1 Aug 2020 23:58:04 +0000 (23:58 +0000)]
Merge branch 'wip/baedert/for-master' into 'master'
Wip/baedert/for master
Closes #2980, #2974, #2949, and #2766
See merge request GNOME/gtk!2333
Timm Bäder [Sat, 1 Aug 2020 18:00:13 +0000 (20:00 +0200)]
Fix and improve various code samples
Timm Bäder [Sat, 1 Aug 2020 17:30:31 +0000 (19:30 +0200)]
aboutdialog: Fix a code sample
gdk_texture_new_from_file takes a GFile these days.
Timm Bäder [Sat, 1 Aug 2020 17:24:54 +0000 (19:24 +0200)]
togglebutton: Modernice source file
Make this a little less ancient looking.
Timm Bäder [Sat, 1 Aug 2020 13:34:59 +0000 (15:34 +0200)]
Avoid refering to old GtkContainer API in the docs
Timm Bäder [Sat, 1 Aug 2020 13:34:07 +0000 (15:34 +0200)]
button: Use g_object_notify_by_pspec()
Timm Bäder [Sat, 1 Aug 2020 13:27:13 +0000 (15:27 +0200)]
stack: Allow NULL names
Does this work?
Timm Bäder [Sat, 1 Aug 2020 13:26:53 +0000 (15:26 +0200)]
stack: Only compare page names if the new page has one
Timm Bäder [Sat, 1 Aug 2020 13:26:28 +0000 (15:26 +0200)]
listbox: Add _append
To have easy replacement API for gtk_container_add.
Timm Bäder [Sat, 1 Aug 2020 08:31:53 +0000 (10:31 +0200)]
adwaita: Reset popover background in backdrop
Otherwise it inherits the generic background color from .background
Fixes #2766
Timm Bäder [Sat, 1 Aug 2020 08:31:38 +0000 (10:31 +0200)]
popover: Use gtk_widget_add_css_class
Timm Bäder [Sat, 1 Aug 2020 07:30:48 +0000 (09:30 +0200)]
window: Keep titlebar after main child
Fixes #2949
Timm Bäder [Sat, 1 Aug 2020 06:56:34 +0000 (08:56 +0200)]
inspector: Avoid some failing casts
We might be inspecting a non-widget here, so can't just cast that.
Timm Bäder [Sat, 1 Aug 2020 06:41:55 +0000 (08:41 +0200)]
textview: Only show "insert emoji" menu item if editable
Fixes #2974
Timm Bäder [Sat, 1 Aug 2020 06:07:43 +0000 (08:07 +0200)]
mediastream demo: Add a weak pointer to the window
Do what other demos do as well.
Fixes 2983
Timm Bäder [Sat, 1 Aug 2020 05:58:36 +0000 (07:58 +0200)]
inspector: Add a type check
We only connect to this signal if sl->obejct is a GtkAccessible, so only
disconnect from it on the same condition.
Fixes #2980
Jordi Mas [Sat, 1 Aug 2020 05:30:25 +0000 (07:30 +0200)]
Update Catalan translation
Rico Tzschichholz [Fri, 31 Jul 2020 19:31:40 +0000 (19:31 +0000)]
Merge branch 'ricotz/for-master' into 'master'
Add annotations to improve GIR API
See merge request GNOME/gtk!2332
Rico Tzschichholz [Fri, 31 Jul 2020 17:12:40 +0000 (19:12 +0200)]
gtk: Add annotations to improve GIR API
Rico Tzschichholz [Fri, 31 Jul 2020 17:12:12 +0000 (19:12 +0200)]
gsk: Add annotations to improve GIR API
Rico Tzschichholz [Fri, 31 Jul 2020 17:11:23 +0000 (19:11 +0200)]
gdk/x11: Add annotations to improve GIR API
Matthias Clasen [Fri, 31 Jul 2020 18:52:50 +0000 (18:52 +0000)]
Merge branch 'glib-build-fix' into 'master'
widget: Drop unnecessary includes
See merge request GNOME/gtk!2328
Matthias Clasen [Fri, 31 Jul 2020 18:20:11 +0000 (14:20 -0400)]
meson: Try to limit the damage
Try to teach meson not to build our subprojects with
-Werror, since that is just insane, and exposes us
to random build failures in subprojects.
Matthias Clasen [Fri, 31 Jul 2020 17:39:22 +0000 (17:39 +0000)]
Merge branch 'dont-always-inline' into 'master'
gsk: Don't the always_inline function attribute
See merge request GNOME/gtk!2331
Matthias Clasen [Fri, 31 Jul 2020 17:37:29 +0000 (13:37 -0400)]
testgtk: More GTimeVal eradication
Matthias Clasen [Fri, 31 Jul 2020 17:13:46 +0000 (13:13 -0400)]
gsk: Don't the always_inline function attribute
Visual C doesn't understand it, and the compiler
should know better, anyway.
Matthias Clasen [Fri, 31 Jul 2020 17:10:47 +0000 (17:10 +0000)]
Merge branch 'master.win32' into 'master'
Some improvements for GDK/Win32
See merge request GNOME/gtk!2327
Matthias Clasen [Fri, 31 Jul 2020 17:10:05 +0000 (17:10 +0000)]
Merge branch 'wip/carlosg/cursor-fallout' into 'master'
gdk: Fix toplevel calculation on pointer grab switch
Closes #2970
See merge request GNOME/gtk!2330
Matthias Clasen [Fri, 31 Jul 2020 17:07:31 +0000 (13:07 -0400)]
Bump the glib dependency
Some of the new apis we want to use to avoid
deprecations were only introduced in 2.65.
Matthias Clasen [Fri, 31 Jul 2020 16:18:54 +0000 (12:18 -0400)]
placesview: Keep up with GLib deprecations
We were using deprecated GBookmarkFile api here too.
Carlos Garnacho [Fri, 31 Jul 2020 16:46:47 +0000 (18:46 +0200)]
gdk: Fix toplevel calculation on pointer grab switch
This check used to read if (grab || device_type != GDK_DEVICE_TYPE_PHYSICAL),
the grab check was only reserved to physical devices, which the current
pointer device definitely doesn't act like. So the condition was "fixed" the
wrong way around, and the latter check is now moot, so the condition should
really go away. We always want to check the new toplevel under the pointer
here.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2970
Matthias Clasen [Fri, 31 Jul 2020 16:33:46 +0000 (16:33 +0000)]
Merge branch 'cups-build-fix' into 'master'
Fix the build with cups < 2.3
Closes #2968
See merge request GNOME/gtk!2329
Matthias Clasen [Fri, 31 Jul 2020 16:08:41 +0000 (12:08 -0400)]
recentmanager: Keep up with GLib deprecations
All the time_t based apis in GBookmarkFile have
been deprecated; use GDateTime instead. This
changes a few GtkRecentManager APIs.
Matthias Clasen [Fri, 31 Jul 2020 15:36:03 +0000 (11:36 -0400)]
numericsorter: Ignore deprecations
We use g_value_get_char here; replacing it with
g_value_get_schar is not entirely trivial, so just
ignore deprecations for now.
Matthias Clasen [Fri, 31 Jul 2020 15:22:16 +0000 (11:22 -0400)]
gtkicontheme: Stop using GTimeVal
It has been deprecated and the deprecation warnings
break our -Werror build in ci.
Chun-wei Fan [Wed, 4 Dec 2019 10:41:05 +0000 (18:41 +0800)]
GDK-Win32: Use SetProcessDpiAwarenessContext() where available
This allows us to use DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 for the
DPI awareness mode, which will help us to better support use cases with
multiple monitors. This is actualy a more advaned version of the
current PROCESS_PER_MONITOR_DPI_AWARE via using SetProcessDpiAwareness().
Note that this is not enabled by default, but also enabled via using
GDK_WIN32_PER_MONITOR_HIDPI, as in the PROCESS_PER_MONITOR_DPI_AWARE
case.
Note also, that appliation compatibility settings and DPI-awareness
manifests takes precedence over this API call, as before.
Chun-wei Fan [Mon, 27 Jul 2020 09:02:00 +0000 (17:02 +0800)]
demos: Fix running on Visual Studio builds
We need to mark the non-static callback functions for export.
Chun-wei Fan [Fri, 31 Jul 2020 10:44:10 +0000 (18:44 +0800)]
gskrenderer.c: Default to the GL renderer on Windows too
Since we have now made the Win32 GL contexts share the global context as
the other backends have, we are more ready to use the GL renderer by
default on Windows as well.
Note that currently we can only enable this when not running on
OpenGL/ES as the OpenGL/ES shaders are not ready at this point, and the
OpenGL/ES support that we have from libANGLE does not support full
desktop OpenGL operations.
Chun-wei Fan [Fri, 31 Jul 2020 10:37:05 +0000 (18:37 +0800)]
gdkglcontext-win32.c: Create a global shared GL context
Like the other backends, we ought to create our WGL/EGL GL contexts like
the following:
"Create a global GL context that connects all GL contexts on a display
and lets us share textures between them."
Chun-wei Fan [Mon, 27 Jul 2020 08:59:05 +0000 (16:59 +0800)]
gdksurface-win32.c: Deal with modal and decoration props
Handle these cases, especially the modal case, which we did not handle
previously after the conversion to surface subtypes.
Matthias Clasen [Fri, 31 Jul 2020 14:54:41 +0000 (10:54 -0400)]
x11: Stop using GTimeVal
It has been deprecated, and that is breaking our
ci builds with -Werror.
Matthias Clasen [Fri, 31 Jul 2020 14:34:37 +0000 (10:34 -0400)]
widget: Drop unnecessary includes
We don't need to include gobjectnotifyqueue.c anymore,
since style properties are gone. This should fix the
build with -Werror.
Matthias Clasen [Fri, 31 Jul 2020 14:00:20 +0000 (10:00 -0400)]
Fix the build with cups < 2.3
PPD_CUSTOM_UNKNOWN was introduced in cups 2.3.
Only handle it when we build against a new enough cups.
Fixes: #2968
Florentina Mușat [Fri, 31 Jul 2020 13:42:35 +0000 (13:42 +0000)]
Update Romanian translation
Yuri Chornoivan [Fri, 31 Jul 2020 12:52:54 +0000 (12:52 +0000)]
Update Ukrainian translation
Daniel Mustieles [Fri, 31 Jul 2020 11:48:24 +0000 (13:48 +0200)]
Updated Spanish translation
Matthias Clasen [Thu, 30 Jul 2020 12:36:01 +0000 (08:36 -0400)]
3.99.0
Matthias Clasen [Fri, 31 Jul 2020 02:15:56 +0000 (22:15 -0400)]
testsuite: Use Wayland by default
I'm tired of xwayland crashing and killing my shell.
Matthias Clasen [Thu, 30 Jul 2020 17:50:54 +0000 (17:50 +0000)]
Merge branch 'focus-active' into 'master'
Focus active
Closes #2390
See merge request GNOME/gtk!2324
Matthias Clasen [Thu, 30 Jul 2020 17:23:45 +0000 (13:23 -0400)]
eventcontrollerkey: Update im focus when active window changes
Use the new GTK_CROSSING_ACTIVE crossing events to update
the im context focus when the window becomes active or
inactive. IBus requires this, since it has only a single,
global focus location.
Fixes: #2390
Matthias Clasen [Thu, 30 Jul 2020 17:22:26 +0000 (13:22 -0400)]
window: Emit GTK_CROSSING_ACTIVE crossing events
Emit crossing events when the active window changes.
We don't want to emit GTK_CROSSING_FOCUS events, since
every window has its own focus location (focus does not
jump from window to window), so we use the new
GTK_CROSSING_ACTIVE type of crossing event for this.
Matthias Clasen [Thu, 30 Jul 2020 17:21:28 +0000 (13:21 -0400)]
Define GTK_CROSSING_ACTIVE
Document the different crossing event kinds that we use,
and add GTK_CROSSING_ACTIVE. We are going to use it in
the future when the active window changes.
Matthias Clasen [Thu, 30 Jul 2020 17:01:15 +0000 (17:01 +0000)]
Merge branch 'wip/carlosg/more-device-api-cleanup' into 'master'
More device API cleanup
See merge request GNOME/gtk!2323
Carlos Garnacho [Thu, 30 Jul 2020 15:52:28 +0000 (17:52 +0200)]
gdk: Rename gdk_seat_get_physical_devices() to gdk_seat_get_devices()
We don't want to tell what they are, and the distinction is now less
clear. Remove the adjective from the function name.